Skip to content

Don't save empty object into package.json file #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2015
Merged

Don't save empty object into package.json file #1037

merged 1 commit into from
Oct 9, 2015

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 9, 2015

  1. Add plugin that doesn't have plugin variables
  2. Open pacakge.json
  3. We've added: "[plugin-name]-variables": {}

Don't save empty object into package.json file
2bd3494 
1. Add plugin that doesn't have plugin variables
2. Open pacakge.json
3. We've added:  "<plugin-name>-variables": {}
@ns-bot
Copy link

ns-bot commented Oct 9, 2015

Test PASSed.

@dtopuzov
Copy link
Contributor

dtopuzov commented Oct 9, 2015

👍

dtopuzov added a commit that referenced this pull request Oct 9, 2015
@dtopuzov
Merge pull request #1037 from NativeScript/fatme/dont-save-empty-obj-…
f72a9da 
…in-package-json

Don't save empty object into package.json file
@dtopuzov dtopuzov merged commit f72a9da into release Oct 9, 2015
@Fatme Fatme deleted the fatme/dont-save-empty-obj-in-package-json branch October 15, 2015 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fatme @ns-bot @dtopuzov